Re: [PATCH] compat: add compat kernel checker and downloader

From: Andy Whitcroft
Date: Wed Apr 04 2012 - 07:10:18 EST


On Fri, Mar 30, 2012 at 05:23:46PM -0700, Luis R. Rodriguez wrote:
> Andy, so I just noticed that on all Ubuntu PPA (and generic) kernels
> you guys have a broken symlink >= 2.6.33.
>
> /lib/modules/2.6.33-02063305-generic/build/include/asm
>
> points to asm-x86 and that is no longer present after 2.6.33 so any
> module requiring those header files will break now on Ubuntu. I just
> spotted this as some file from asm is now included in the modules were
> are building. I guess not many external kernel modules include asm dir
> otherwise you guys would have noticed this a long time ago.

Luis, I concur that the link is now broken. However that link is actually
simply superfulous now. Anything correctly using kernel 'external
module' support will be using the -I path from the kernel Makefiles.
They will therefore be including from /usr/src/<version>/include _and_
/usr/src/<version>/arch/x86/include. I presume this is why we have not
noticed it.

I will get that link removed however as it is simply bogus.

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/