RE: [PATCH net-next v3 5/5] r8169: support RTL8411
From: hayeswang
Date: Thu Apr 05 2012 - 02:06:29 EST
Francois Romieu [mailto:romieu@xxxxxxxxxxxxx]
> Sent: Friday, March 30, 2012 3:25 PM
> To: Hayeswang
> Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH net-next v3 5/5] r8169: support RTL8411
>
> Hayes Wang <hayeswang@xxxxxxxxxxx> :
> > Support the new chip RTL8411.
> >
> > Signed-off-by: Hayes Wang <hayeswang@xxxxxxxxxxx>
>
> I do not see any change related to rtl_init_jumbo_ops. If
> NULL is ok for
> jumbo_{enable / disable}, it deserves to be outlined in the commit
> message.
>
> No reviewer can figure what's going on otherwise.
>
There is nothing to do for rtl_init_jumbo_ops. It is all right for keeping NULL.
Do I need to resend this patch?
Best Regards,
Hayes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/