Re: [PATCH RFT 2/2] regulator: Convert rc5t583 to set_voltage

From: Laxman Dewangan
Date: Thu Apr 05 2012 - 03:11:25 EST


On Thursday 05 April 2012 11:37 AM, Axel Lin wrote:
Not every regulator driver should implement set_voltage_sel callback.
See commit e8eef82
"regulator: Provide a selector based set_voltage_sel() operation".

For rc5t583, the regulator voltage can be mapped onto selector values with a
simple calculation, thus implement set_voltage is better than set_voltage_sel.

Signed-off-by: Axel Lin<axel.lin@xxxxxxxxx>
---


I wanted to provide the settling delay whenever voltage output get change as per datasheet. In place of having this delay in the driver, I wanted to use implementation of core and for this I need to implement set_voltage_sel() not set_voltage().

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/