RE: [PATCH] serial: 8250: Add cpufreq support

[Shankarmurthy, Akshay]

Hi,

On Tue, Apr 03, 2012 at 15:25:30, Alan Cox wrote:
> > This patch was submitted 2 years ago but didn't make it to the mainline. Now i am reposting it.
> 
> Can you fix it instead of just reposting it ?
> 
> 
> > +#ifdef CONFIG_CPU_FREQ
> > +static int serial8250_cpufreq_transition(struct notifier_block *nb,
> > +					     unsigned long val, void *data)
> > +{
> > +	struct uart_8250_port *p;
> > +	struct uart_port *uport;
> 
> What is your locking model ?
> 

I will have a look at this and add the lock if necessary.

> 
> > +static inline void serial8250_cpufreq_deregister(struct uart_8250_port *p)
> 
> unregister

Ok. I will change it.

> 
> > +		ret = serial8250_cpufreq_register(uart);
> > +		if (ret < 0)
> > +			printk(KERN_ERR "Failed to add cpufreq notifier\n");
> 
> Why do this for devices that don't care.

This is taken care in the code. If the device's frequency doesn't change after the
change in the cpu frequency then it doesn't go for execution of the function "serial8250_set_termios".
It does execute only if the uart clk frequency is changed with a change in the cpu frequency. 
So registering this for the devices that doesn't care will not affect the system. 


Regards,
Akshay
    
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/