Re: [PATCH v5 06/27] irq_domain/powerpc: eliminate irq_map; useirq_alloc_desc() instead

From: Thomas Gleixner
Date: Fri Apr 06 2012 - 07:28:39 EST



On Fri, 6 Apr 2012, Andreas Schwab wrote:

> Thomas Gleixner <tglx@xxxxxxxxxxxxx> writes:
>
> > And it looks like the irqdomain code is the real culprit.
> >
> > void irq_set_virq_count(unsigned int count)
> > {
> > pr_debug("irq: Trying to set virq count to %d\n", count);
> >
> > BUG_ON(count < NUM_ISA_INTERRUPTS);
> > if (count < NR_IRQS)
> > irq_virq_count = count;
> > }
> >
> > That looks simply wrong.....
>
> There is a single use of irq_set_virq_count, which is only relevant to
> the PS3.

Though irq_virq_count is statically initialized to NR_IRQS and it's
used in the code more than once.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/