Re: [PATCH 1/1] leds: Add LED driver for lm3556 chip

[Andrew Morton]

On Sat, 31 Mar 2012 21:37:23 -0600
Shuah Khan <shuahkhan@xxxxxxxxx> wrote:

> > +	ret = kstrtoul(buf, 10, &state);
> > +	if (ret)
> > +		goto out;
> >  	if (isspace(*after))
> >  		count++;
> 
> after is used without initialization. Please note that simple_strtoul()
> initializes after. Don't think this will work.

I didn't try very hard ;)

I think I'll drop the whole patch.  According to my notes,

- Wolfram's comments should be addressed
- Move the header file out of include/linux/
- Consider using the regmap API
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/