Re: tools/virtio: Compile errors

[Michael S. Tsirkin]

On Mon, Apr 09, 2012 at 02:02:53PM +0800, Zhi Yong Wu wrote:
> On Thu, Feb 9, 2012 at 12:47 AM, Michael S. Tsirkin <mst@xxxxxxxxxx> wrote:
> > On Wed, Feb 08, 2012 at 05:04:05PM +0100, Dongsu Park wrote:
> >> Hi,
> >>
> >> there are compile problems under tools/virtio.
> >> If I simply run make,
> >>
> >> ~/linuxsrc/linux-3.2/tools/virtio $ make
> >> gcc -g -O2 -Wall -I. -I ../../usr/include/ -Wno-pointer-sign
> >> -fno-strict-overflow  -MMD   -c -o virtio_ring.o
> >> ../../drivers/virtio/virtio_ring.c
> >> ../../drivers/virtio/virtio_ring.c:24:26: fatal error: linux/module.h:
> >> No such file or directory
> >> compilation terminated.
> >> make: *** [virtio_ring.o] Error 1
> >
> >
> >> By the way, my system is Ubuntu 11.10 with Kernel 3.2.
> >>
> >> Cheers,
> >> Dongsu
> >
> > This patch is missing - I'll put it upstream.
> >
> > --->
> >
> > tools/virtio: add module.h stub
> >
> > make it build with linux 3.2
> >
> > Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> >
> > diff --git a/tools/virtio/linux/module.h b/tools/virtio/linux/module.h
> > new file mode 100644
> > index 0000000..96868eb
> > --- /dev/null
> > +++ b/tools/virtio/linux/module.h
> > @@ -0,0 +1,3 @@
> > +#ifndef LINUX_MODULE_H
> > +#define LINUX_MODULE_H
> > +#endif
> After the patch was applied in my env, i met another issue.
> [root@f15 virtio]# make test
> cc -g -O2 -Wall -I. -I ../../usr/include/ -Wno-pointer-sign
> -fno-strict-overflow  -MMD   -c -o virtio_ring.o
> ../../drivers/virtio/virtio_ring.c
> ../../drivers/virtio/virtio_ring.c: In function \u2018virtqueue_add_buf\u2019:
> ../../drivers/virtio/virtio_ring.c:277:2: warning: implicit
> declaration of function \u2018wmb\u2019
> [-Wimplicit-function-declaration]
> ../../drivers/virtio/virtio_ring.c: In function \u2018virtqueue_get_buf\u2019:
> ../../drivers/virtio/virtio_ring.c:437:2: warning: implicit
> declaration of function \u2018rmb\u2019
> [-Wimplicit-function-declaration]
> cc   virtio_test.o virtio_ring.o   -o virtio_test
> virtio_ring.o: In function `virtqueue_add_buf':
> /home/zwu/work/kernel/vhost-scsi/tools/virtio/../../drivers/virtio/virtio_ring.c:277:
> undefined reference to `wmb'
> virtio_ring.o: In function `virtqueue_get_buf':
> /home/zwu/work/kernel/vhost-scsi/tools/virtio/../../drivers/virtio/virtio_ring.c:437:
> undefined reference to `rmb'
> collect2: ld returned 1 exit status
> make: *** [virtio_test] Error 1

On which kernel version does this trigger?

> 
> 
> -- 
> Regards,
> 
> Zhi Yong Wu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/