Re: [PATCH 0/5] ACPI: Add _OST support for ACPI hotplug

[Shuah Khan]

> Hi Shuah,
> 
> The fake _OST methods print arguments to verify successful execution of
> the methods.  Since the purpose of _OST is firmware-internal
> communication, there is no difference in testing on real firmware from
> the OS perspective.  Overriding DSDT with fake ACPI methods is a
> well-established and widely used testing method as well.

Toshi,

This patch hasn't gone through sufficient new functionality testing as
the only testing that was done was exercising it with stubbed out
firmware calls. I am not clear on how much regression testing this patch
has undergone. Sorry, it doesn't give me the warm and fuzzies.

-- Shuah


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/