Re: Weirdness in __alloc_bootmem_node_high
From: Yinghai Lu
Date: Fri Apr 20 2012 - 15:30:52 EST
On Fri, Apr 20, 2012 at 12:14 PM, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:
>
> I took a quick look at this.
> __alloc_bootmem_node_high() is used in mm/sparse.c - but only
> if SPARSEMEM_VMEMMAP is enabled.
>
> mips has this:
>
> config ARCH_SPARSEMEM_ENABLE
> bool
> select SPARSEMEM_STATIC
>
> So SPARSEMEM_VMEMMAP is not enabled.
>
> __alloc_bootmem_node_high() is used in mm/sparse-vmemmap.c which
> also depends on CONFIG_SPARSEMEM_VMEMMAP.
>
>
> So I really do not see the logic in __alloc_bootmem_node_high()
> being used anymore and it can be replaced by __alloc_bootmem_node()
Yes, you are right. __alloc_bootmem_node_high could be removed.
BTW, x86 is still the only one that use NO_BOOTMEM.
Are you working on making sparc to use NO_BOOTMEM?
Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/