Re: [PATCH] alpha: add io{read,write}{16,32}be functions

From: Jonathan Nieder
Date: Tue Apr 24 2012 - 01:51:26 EST


Hi Matt et al,

Michael Cree wrote:

> These functions are used in some PCI drivers with big-endian
> MMIO space.
>
> Admittedly it is almost certain that no one this side of the
> Moon would use such a card in an Alpha but it does get us
> closer to being able to build allyesconfig or allmodconfig,
[...]
> --- a/arch/alpha/include/asm/io.h
> +++ b/arch/alpha/include/asm/io.h
> @@ -490,6 +490,11 @@ extern inline void writeq(u64 b, volatile void __iomem *addr)
> }
> #endif
>
> +#define ioread16be(p) be16_to_cpu(ioread16(p))
> +#define ioread32be(p) be32_to_cpu(ioread32(p))
> +#define iowrite16be(v,p) iowrite16(cpu_to_be16(v), (p))
> +#define iowrite32be(v,p) iowrite32(cpu_to_be32(v), (p))
> +
> #define inb_p inb

This patch has been in use in Debian's development branch since
January. Does it look sensible to you? (If so, I'd like to see it in
mainline eventually so we can more easily share bugfixes depending on
it in the future.)

Thanks,
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-alpha" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html