Re: [PATCH 5/9 v2] gpio/nomadik: use ioremap() instead of static mappings

From: Linus Walleij
Date: Tue Apr 24 2012 - 03:38:36 EST


On Mon, Apr 23, 2012 at 1:34 PM, Russell King - ARM Linux
<linux@xxxxxxxxxxxxxxxx> wrote:
> On Mon, Apr 23, 2012 at 01:30:32PM +0200, Linus Walleij wrote:
>> diff --git a/drivers/gpio/gpio-nomadik.c b/drivers/gpio/gpio-nomadik.c
>> index 7b45d88..bddc3dd 100644
>> --- a/drivers/gpio/gpio-nomadik.c
>> +++ b/drivers/gpio/gpio-nomadik.c
>> @@ -28,7 +28,6 @@
>>
>>  #include <plat/pincfg.h>
>>  #include <plat/gpio-nomadik.h>
>> -#include <mach/hardware.h>
>>  #include <asm/gpio.h>
>
> While you're here, please replace this with linux/gpio.h - which will give
> us one less direct dependency on asm/ or mach/ includes from drivers.

OK I just deleted it, <linux/gpio.h> was included further up, so
this was just some dangling include anyway.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/