[Bother! Resending with corrected subject line (was "[PATCH 1/2]
prctl: Add PR_SET_MM option description")]
Cyrill,
While reviewing your patch to the prctl() manual page, I noticed the
following code in kernel/sys.c::prctl_set_mm():
if (opt != PR_SET_MM_START_BRK&& opt != PR_SET_MM_BRK) {
/* It must be existing VMA */
if (!vma || vma->vm_start> addr)
goto out;
}
At this point, the code causes an exit with error set to zero (i.e.,
success). This looks unintended to me. Is the code correct? I suspect
a return of -EFAULT or -ENOMEM is warranted.