Re: [PATCH V2] i2c: Add generic I2C multiplexer using pinctrl API

From: Stephen Warren
Date: Tue Apr 24 2012 - 17:02:46 EST


On 04/24/2012 02:09 PM, Wolfram Sang wrote:
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/i2c/pinctrl-i2cmux.txt
>> @@ -0,0 +1,79 @@
>> +Pinctrl-based I2C Bus Mux
>> +
>> +This binding describes an I2C bus multiplexer that uses pin multiplexing to
>> +route the I2C signals, and represents the pin multiplexing configuration
>> +using the pinctrl device tree bindings.
>> +
>> +Required properties:
>> +- compatible: pinctrl-i2cmux
>
> From what I know, compatible-properties should not be linux-specific
> since devicetrees are OS independent. pinctrl-i2cmux sounds
> linux-specific to me.
>
> So, is such a binding acceptable meanwhile?

To my mind, "pinctrl" has two meanings: (1) is the Linux internal API
(2) is the pinctrl bindings in
Documentation/devicetree/bindings/pinctrl, which were admittedly
developed strongly based on Linux's pinctrl API needs, but I believe
should be completely agnostic to the pinctrl API, SW, OS, etc., and
hence can be considered a pure representation of hardware.

As such, the "pinctrl" in "pinctrl-i2cmux" above refers to (2) above,
and can be considered a pure HW/binding term.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/