Re: [RFC/PATCH] Prevent wasting time to find out get_parent_ip

From: Minho Ban
Date: Tue Apr 24 2012 - 19:31:39 EST


On 04/24/2012 09:53 PM, Peter Zijlstra wrote:
> On Tue, 2012-04-24 at 21:36 +0900, Minho Ban wrote:
>> trace_preempt_on/off looks empty if PREEMPT_TRACER is off. But actually it is
>> spending time to find out get_parent_ip(even CALLER_ADDR for some ARCH) which is
>> in argument. This seems not fair for those who expect to do nothing but increase
>> or decrease count.
>
> You can do the same by making them CPP macros and adding a comment as to
> why they're macros instead of inlines..
>

Thank you for pointing this out, certainly macros look better. I'll amend this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/