Re: [PATCH v2] Add support for TCA6424A

From: Linus Walleij
Date: Wed Apr 25 2012 - 13:06:06 EST


On Wed, Apr 25, 2012 at 3:18 PM, Andreas Schallenberg
<Andreas.Schallenberg@xxxxxxxxxxxxxxxxxx> wrote:

> From 3fcb45bad283740a48c17ff078c28dd1354204ae Mon Sep 17 00:00:00 2001
> From: Andreas Schallenberg <Andreas.Schallenberg@xxxxxxxxxxxxxxxxxx>
> Date: Wed, 25 Apr 2012 14:51:30 +0200
> Subject: [PATCH] Add support for TCA6424A
>
> This patch extends the PCA953x driver to support TI's TCA6424A 24 bit I2C I/O expander.
> The patch is on code by Michele Bevilacqua.
>
> Changes in v2:
> - Compare ngpio against 24 in both places, not >16
> - Larger datatype now u32 instead of uint.
>  Bit fields not used for struct members since their address is taken.
> - Be precise: TCA6424A (untested for older TCA6424)
>
> Should the chip name string read tca6424a as well?
>
> Signed-off-by: Andreas Schallenberg<Andreas.Schallenberg@xxxxxxxxxxxxxxxxxx>

Looks good to me. Would be good to have this tested on the other
family members though.
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/