Re: linux-next: build warning after merge of the akpm tree

From: Stephen Rothwell
Date: Fri Apr 27 2012 - 02:29:33 EST


Hi Cyrill,

On Fri, 27 Apr 2012 10:22:18 +0400 Cyrill Gorcunov <gorcunov@xxxxxxxxxx> wrote:
>
> On Fri, Apr 27, 2012 at 03:44:20PM +1000, Stephen Rothwell wrote:
> >
> > After merging the akpm tree, today's linux-next build ()
> > produced this warning:
> >
> > kernel/sys.c: In function 'prctl_set_mm':
> > kernel/sys.c:1779:6: warning: 'error' may be used uninitialized in this function [-Wuninitialized]
> >
> > And this is not a false positive (I think).
> >
> > Introduced by commit 5455a20be1a6 ("c/r: prctl: extend PR_SET_MM to set
> > up more mm_struct entries").
>
> Hi Stephen, thanks for report, have no idea how it happened, since
> commit 5455a20be1a6 _has_ error = -EINVAL; line.

I blamed the wrong patch :-(

Commit 8f62e9e9ed ("c/r: prctl: simplify PR_SET_MM on mm::code/data
assignment") removes the "error = -EINVAL".

--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx

Attachment: pgp00000.pgp
Description: PGP signature