[tip:perf/core] perf annotate browser: Add visual cue for retq instruction

From: tip-bot for Arnaldo Carvalho de Melo
Date: Fri Apr 27 2012 - 04:40:22 EST


Commit-ID: 4ea08b522071c6c34098b7a880aac3551abecd75
Gitweb: http://git.kernel.org/tip/4ea08b522071c6c34098b7a880aac3551abecd75
Author: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
AuthorDate: Fri, 20 Apr 2012 15:51:40 -0300
Committer: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
CommitDate: Fri, 20 Apr 2012 15:51:40 -0300

perf annotate browser: Add visual cue for retq instruction

Just use a left arrow prefixing retqs.

Requested-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Cc: David Ahern <dsahern@xxxxxxxxx>
Cc: Frederic Weisbecker <fweisbec@xxxxxxxxx>
Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Cc: Mike Galbraith <efault@xxxxxx>
Cc: Namhyung Kim <namhyung@xxxxxxxxx>
Cc: Paul Mackerras <paulus@xxxxxxxxx>
Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Cc: Stephane Eranian <eranian@xxxxxxxxxx>
Link: http://lkml.kernel.org/n/tip-tnpfijuomrntbnl5vr6ibdwa@xxxxxxxxxxxxxx
Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
---
tools/perf/ui/browsers/annotate.c | 17 +++++++++++++----
1 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c
index 63206ca..d0c606e 100644
--- a/tools/perf/ui/browsers/annotate.c
+++ b/tools/perf/ui/browsers/annotate.c
@@ -127,11 +127,20 @@ static void annotate_browser__write(struct ui_browser *self, void *entry, int ro

dl->ins->ops->scnprintf(dl->ins, bf, sizeof(bf), &dl->ops,
!ab->use_offset);
- printed += 2;
- } else
- scnprintf(bf, sizeof(bf), " %-6.6s %s", dl->name, dl->ops.raw);
+ } else {
+ if (strcmp(dl->name, "retq")) {
+ slsmg_write_nstring(" ", 2);
+ } else {
+ SLsmg_set_char_set(1);
+ SLsmg_write_char(SLSMG_LARROW_CHAR);
+ SLsmg_set_char_set(0);
+ SLsmg_write_char(' ');
+ }
+
+ scnprintf(bf, sizeof(bf), "%-6.6s %s", dl->name, dl->ops.raw);
+ }

- slsmg_write_nstring(bf, width - 10 - printed);
+ slsmg_write_nstring(bf, width - 12 - printed);
}

if (current_entry)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/