[PATCH] sysfs: Redundant assignment of dup_name in sysfs_rename

From: Sasikantha babu
Date: Fri Apr 27 2012 - 10:28:57 EST


It is redundant to assign "kstrdup" of "new_value" to "dup_name",
Since we are overwriting "dup_name" with "sd->s_name"

Signed-off-by: Sasikantha babu <sasikanth.v19@xxxxxxxxx>
---
fs/sysfs/dir.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c
index 35a36d3..4abd424 100644
--- a/fs/sysfs/dir.c
+++ b/fs/sysfs/dir.c
@@ -875,7 +875,7 @@ int sysfs_rename(struct sysfs_dirent *sd,
/* rename sysfs_dirent */
if (strcmp(sd->s_name, new_name) != 0) {
error = -ENOMEM;
- new_name = dup_name = kstrdup(new_name, GFP_KERNEL);
+ new_name = kstrdup(new_name, GFP_KERNEL);
if (!new_name)
goto out;

--
1.7.3.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/