Re: [PATCH v2] sysfs: Removed dup_name entirely in sysfs_rename

[Sasikanth babu]

On Mon, Apr 30, 2012 at 7:21 PM, Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Mon, Apr 30, 2012 at 03:16:56PM +0530, Sasikantha babu wrote:
>> Since no one using "dup_name", removed it completely in sysfs_rename,
>>
>> Signed-off-by: Sasikantha babu <sasikanth.v19@xxxxxxxxx>
>> ---
>>  fs/sysfs/dir.c |    6 ++----
>>  1 files changed, 2 insertions(+), 4 deletions(-)
>
> Have you tested this patch and renamed some sysfs files with it with
> SLAB_DEBUGGING enabled?  There was some "odd" things with regards to
> names that I would like to ensure that is all still working properly
> with this patch.
>
> thanks,
>
> greg k-h

I had enabled SLAB debugging and  tested this patch by modifying few
existing sysfs entries and
newly created entries.

[sasikantha@localhost linux-2.6]$ cat .config | grep SLAB
CONFIG_SLAB=y
CONFIG_SLABINFO=y
CONFIG_DEBUG_SLAB=y
CONFIG_DEBUG_SLAB_LEAK=y
[sasikantha@localhost linux-2.6]$

Did not face any issues while renaming.

Please let me know if there is any specific scenario that needs to be tested.

Thanks
Sasi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/