Re: [PATCH] [RESEND] Install kernel-page-flags.h

[KOSAKI Motohiro]

(4/29/12 10:04 AM), Ulrich Drepper wrote:
> No one has definitely commented on this patch nor is it applied.  Christoph at first said it shouldn't be done but I think he had to retract his objection.  The interface is already out there.  It's also IMO the right choice to go with a binary interface since there is so much data involved and the format is not tied directly to kernel-internal data structures.
> 
> Could either the patch please be applied or a reason given why not?
> 
> 
> Signed-off-by: Ulrich Drepper<drepper@xxxxxxxxx>
> 

linux/Documentation/vm/page-type.c has redundant definition of KPF_*. then, this exporting will solve it.
I'm going to ack if you can fix two things.
 1) your current changelog looks like a chat log style. Please write formal changelog.
 2) Please fix page-type.c too.

and pelase cc Wu Fengguang <fengguang.wu@xxxxxxxxx>. His last commit explicitly says kernel-page-flags.h
was intentionally made for user space tools. see below.


commit 1a9b5b7fe0c5dad8a635288882d36785dea742f9
Author: Wu Fengguang <fengguang.wu@xxxxxxxxx>
Date:   Wed Dec 16 12:19:59 2009 +0100

    mm: export stable page flags
    
    Rename get_uflags() to stable_page_flags() and make it a global function
    for use in the hwpoison page flags filter, which need to compare user
    page flags with the value provided by user space.
    
    Also move KPF_* to kernel-page-flags.h for use by user space tools.
    
    Acked-by: Matt Mackall <mpm@xxxxxxxxxxx>
    Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>
    CC: Nick Piggin <npiggin@xxxxxxx>
    CC: Christoph Lameter <cl@xxxxxxxxxxxxxxxxxxxx>
    Signed-off-by: Wu Fengguang <fengguang.wu@xxxxxxxxx>
    Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/