Re: [patch 5/5] mm: refault distance-based file cache sizing

[Andrea Arcangeli]

On Tue, May 01, 2012 at 10:41:53AM +0200, Johannes Weiner wrote:
> frequently used active page.  Instead, for each refault with a
> distance smaller than the size of the active list, we deactivate an

Shouldn't this be the size of active list + size of inactive list?

If the active list is 500M, inactive 500M and the new working set is
600M, the refault distance will be 600M, it won't be smaller than the
size of the active list, and it won't deactivate the active list as it
should and it won't be detected as working set.

Only the refault distance bigger than inactive+active should not
deactivate the active list if I understand how this works correctly.

> @@ -1726,6 +1728,11 @@ zonelist_scan:
>  		if ((alloc_flags & ALLOC_CPUSET) &&
>  			!cpuset_zone_allowed_softwall(zone, gfp_mask))
>  				continue;
> +		if ((alloc_flags & ALLOC_WMARK_LOW) &&
> +		    current->refault_distance &&
> +		    !workingset_zone_alloc(zone, current->refault_distance,
> +					   &distance, &active))
> +			continue;
>  		/*
>  		 * When allocating a page cache page for writing, we
>  		 * want to get it from a zone that is within its dirty

It's a bit hard to see how this may not run oom prematurely if the
distance is always bigger, this is just an implementation question and
maybe I'm missing a fallback somewhere where we actually allocate
memory from whatever place in case no place is ideal.

> +	/*
> +	 * Lower zones may not even be full, and free pages are
> +	 * potential inactive space, too.  But the dirty reserve is
> +	 * not available to page cache due to lowmem reserves and the
> +	 * kswapd watermark.  Don't include it.
> +	 */
> +	zone_free = zone_page_state(zone, NR_FREE_PAGES);
> +	if (zone_free > zone->dirty_balance_reserve)
> +		zone_free -= zone->dirty_balance_reserve;
> +	else
> +		zone_free = 0;

Maybe also remove the high wmark from the sum? It can be some hundred
meg so it's better to take it into account, to have a more accurate
math and locate the best zone that surely fits.

For the same reason it looks like the lowmem reserve should also be
taken into account, on the full sum.

> +	if (missing >= zone_active + zone_free) {

This seems a place where to add the zone_inactive too according to my
comment on top.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/