Re: [PATCH 35/41] sched: Update rq clock before idle balancing

[Michael Wang]

On 05/01/2012 07:55 AM, Frederic Weisbecker wrote:

> idle_balance() is called from schedule() right before we schedule the
> idle task. It needs to record the idle timestamp at that time and for
> this the rq clock must be accurate. If the CPU is running tickless
> we need to update the rq clock manually.
> 
> Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> Cc: Alessio Igor Bogani <abogani@xxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: Avi Kivity <avi@xxxxxxxxxx>
> Cc: Chris Metcalf <cmetcalf@xxxxxxxxxx>
> Cc: Christoph Lameter <cl@xxxxxxxxx>
> Cc: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> Cc: Geoff Levand <geoff@xxxxxxxxxxxxx>
> Cc: Gilad Ben Yossef <gilad@xxxxxxxxxxxxx>
> Cc: Hakan Akkan <hakanakkan@xxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Kevin Hilman <khilman@xxxxxx>
> Cc: Max Krasnyansky <maxk@xxxxxxxxxxxx>
> Cc: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Stephen Hemminger <shemminger@xxxxxxxxxx>
> Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> Cc: Sven-Thorsten Dietrich <thebigcorporation@xxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> ---
>  kernel/sched/fair.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index eff80e0..cd871e7 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -4638,6 +4638,7 @@ void idle_balance(int this_cpu, struct rq *this_rq)
>  	int pulled_task = 0;
>  	unsigned long next_balance = jiffies + HZ;
> 
> +	update_nohz_rq_clock(this_rq);


I'm not sure but why we have to care nohz? if we really need an accurate
clock, we should do the update anyway, don't we?

Some thing also confused me is the description:
"If the CPU is running tickless we need to update the rq clock manually."

I think the cpu will enter tickless mode only when the idle thread
already switched in, then invoke
tick_nohz_idle_enter->tick_nohz_stop_sched_tick, isn't it?

And if we invoke idle_balance for a cpu, that means it hasn't enter
idle(current task is not idle task), so how can such a cpu in tickless mode?

Regards,
Michael Wang

>  	this_rq->idle_stamp = this_rq->clock;
> 
>  	if (this_rq->avg_idle < sysctl_sched_migration_cost)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/