Re: [PATCH -v11 04/30] PCI: Add busn_res into struct pci_bus.
From: Yinghai Lu
Date: Wed May 02 2012 - 01:07:49 EST
On Tue, May 1, 2012 at 12:28 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
> On Tue, May 1, 2012 at 8:40 AM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:
>>>> bridge's Subordinate Bus Number in config space == bus->subordinate ==
>>>> bus->busn_res.end (correct me if I'm wrong). I don't like the
>>>> redundancy in this case.
>>>
>>> there are about 70 bus->subordinate reference and 40 bus->secondary reference.
>>>
>>> could try to update them in following patch set.
>>
>> If you're proposing this:
>> 1. add bus->busn_res
>> 2. remove bus->subordinate and bus->secondary
>> I fully support that, and I'd like to merge both pieces at the same
>> time (different patches is fine; I just want to make sure both pieces
>> actually happen).
>
> yes. Can you consider applying "removing bus->subordinate" patch set
> to be applied after:
> for-pci-busn-alloc
> for-pci-root-bus-hotplug
> for-pci-for-each-res-addon
> for-pci-res-alloc
>
> otherwise there would be some extra rebase work for last three patch set.
spent several hours today to have attached patch that will remove
pci_bus secondary/subordinate.
and tested with my setups with remove/scan test case.
looks ok.
need to apply it after
for-pci-busn-alloc
for-pci-root-bus-hotplug.
Please check if i miss anything.
Thanks
Yinghai
Attachment:
kill_bus_subordinate_x.patch
Description: Binary data