Re: [PATCH v2 1/3] ARM: imx: Add common imx cpuidle init functionality.

From: Shawn Guo
Date: Wed May 02 2012 - 10:07:25 EST


On 2 May 2012 21:59, Rob Lee <rob.lee@xxxxxxxxxx> wrote:
>>> +             ret = cpuidle_register_device(dev);
>>> +             if (ret) {
>>> +                     pr_err("%s: Failed to register cpu %u\n",
>>> +                             __func__, cpu_id);
>>
>> Nit: print ret (error code) too?
>>
>
> I added the printing of the error code based on Sascha's suggestion in
> v1 of this submission.
>
But you did not print "ret" in above pr_err.

Regards,
Shawn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/