Re: [PATCH v6 1/3] trace: Make removal of ring buffer pages atomic

From: Vaibhav Nagarnaik
Date: Thu May 03 2012 - 14:43:49 EST


On Thu, May 3, 2012 at 7:12 AM, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> It's also giving me errors when I try to enable events or anything else
> when tracing_on is disabled.

Yes, I had to add a check to see if resizing is safe. I re-used
record_disabled in this patch for that purpose.

In the next patch for "atomic addition of pages" I added a new field
resize_disabled to guard against unsafe resizing. So with that patch,
you won't see this behavior. It also fixes the issue with trace-cmd
where the ring buffer doesn't get expanded.



Vaibhav Nagarnaik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/