Re: [PATCH 5/9] perf: Add Nehalem and Sandy Bridge uncore support

[Yan, Zheng]

On 05/04/2012 05:04 AM, Peter Zijlstra wrote:
> On Wed, 2012-05-02 at 10:07 +0800, Yan, Zheng wrote:
>>         switch (boot_cpu_data.x86_model) {
>> +       case 26: /* Nehalem */
>> +       case 30:
>> +       case 31:
>> +       case 37: /* Westmere */
>> +               msr_uncores = nhm_msr_uncores;
>> +               break;
>> +       case 42: /* Sandy Bridge */
>> +               msr_uncores = snb_msr_uncores;
>> +               break;
>>         default:
>>                 return 0;
>>         } 
> 
> I really hate we're duplicating all these things all over the place, but
> I don't really know what to do about it either.
> 
> Anyway, it looks like perf_event_intel.c is missing 31, that said I
> cannot seem to find model 31 on wikipedia either.
> 
Sorry. the number 31 is copied from Lin Ming's old uncore patch. Now both
Lin Ming and I can't find the model 31 processor. I will remove the 31 in
future patches. 

> What about 44, WSM-EP ?
> 
> I understand NHM-EX (46) and WSM-EX (47) have different uncores not
> implemented in this series, will those follow?
Yes, I just start reading the SDM.

Regards
Yan, Zheng

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/