RE: [PATCH] max17042_battery: Fix power supply and irq registrationordering

[Pallala, Ramakrishna]

> On Sat, May 05, 2012 at 03:08:37AM +0530, Ramakrishna Pallala wrote:
> > IRQ registration should happen only after power supply object usable.
> > This patch fixes the ordering of power supply and irq registration
> > calls.
> >
> > Signed-off-by: Ramakrishna Pallala <ramakrishna.pallala@xxxxxxxxx>
> > ---
> 
> Applied, thank you!
> 
> And I noticed another small issue: if request_threaded_irq() fails, we continue with
> probing (which is OK), but since request failed, during max17042_remove() and
> suspend/resume we would call IRQ routines on a non-requested IRQ.
> 
> So, probably you'd want to set client->irq = 0 when request_irq fails.
> 

right, I should have checked this :(
I will submit the fix.

Thanks,
Ram
èº{.nÇ+‰·Ÿ®‰­†+%ŠËlzwm…ébëæìr¸›zX§»®w¥Š{ayºÊÚë,j­¢f£¢·hš‹àz¹®w¥¢¸¢·¦j:+v‰¨ŠwèjØm¶Ÿÿ¾«‘êçzZ+ƒùšŽŠÝj"ú!¶iO•æ¬z·švØ^¶m§ÿðÃnÆàþY&—