Re: [PATCH 09/14 v3] Input: atmel_mxt_ts - refactor get info

[Daniel Kurtz]

On Sun, May 6, 2012 at 1:41 AM, Nick Dyer <nick.dyer@xxxxxxxxxxx> wrote:
> Hi Daniel-
>
> Daniel Kurtz wrote:
>> -     dev_info(&client->dev,
>> -                     "Family ID: %d Variant ID: %d Version: %d Build: %d\n",
>> -                     info->family_id, info->variant_id, info->version,
>> -                     info->build);
>> +     dev_info(dev, "Family ID: %d Variant ID: %d Major.Minor.Build: %d.%d.%d\n",
>> +              info->family_id, info->variant_id, info->version >> 4,
>> +              info->version & 0xf, info->build);
>
> The canonical format for the Atmel firmware versions has the build number
> in hex, eg. 2.0.AA
>
> So it should be %d.%d.%02X

Nick,
Thanks!  Will update.  Or perhaps %u.%u.%02X ?
-Daniel

>
> cheers
>
> Nick
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/