Re: [PATCH] ISP1704 USB Charger: Fix use-after-free error inisp1704_charger_probe()

[Jesper Juhl]

Sorry about the late reply, I've been away from my mailbox for a while.

On Sat, 5 May 2012, Anton Vorontsov wrote:

> On Sun, Apr 22, 2012 at 10:34:59PM +0200, Marek Vasut wrote:
> [...]
> > > -
> > >  	dev_err(&pdev->dev, "failed to register isp1704 with error %d\n", ret);
> > > -
> > >  	isp1704_charger_set_power(isp, 0);
> > > +	kfree(isp);
> 
> Dan Carpenter sent a similar fix ~month ago, so it's in already.
> 
Ok :)

> > Use devm_kzalloc() and be done with all this goo?
> 
> Yeah, that's actually a good idea.
> 
No promises, but I may look into this in a few days.

-- 
Jesper Juhl <jj@xxxxxxxxxxxxx>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/