Re: [PATCH v2 2/2] perf ui/gtk: Use struct perf_error_ops

[Namhyung Kim]

Hi,

On Mon, 7 May 2012 10:17:41 +0300, Pekka Enberg wrote:
> On Mon, May 7, 2012 at 9:03 AM, Namhyung Kim <namhyung.kim@xxxxxxx> wrote:
>> Define and use perf_gtk_eops to provide a GTK2 message
>> dialog for error reporting. To do that, we need global
>> main_window variable for tracking UI state.
>>
>> Signed-off-by: Namhyung Kim <namhyung.kim@xxxxxxx>
>
> I still don't like the dialog-based approach because it requires the
> *user* to respond. Just add a label to the GTK window and show the
> latest message there. If you want to make it even prettier, make the
> label clickable and open up a popup that shows all the warnings and
> errors in a separate window...

As I said before, most of calls to ui__warning/error are called just
before the main window is closed or critical enough to require user's
reponse - if not, it probably needs to use other API.

So I think it's OK for the current symantics of the API.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/