Re: [PATCH] ramster: depend on CONFIG_NET for sock_* functions

[Sasha Levin]

On Mon, May 7, 2012 at 10:43 AM, Paul Bolle <pebolle@xxxxxxxxxx> wrote:
> On Mon, 2012-05-07 at 10:29 +0200, Sasha Levin wrote:
>> On Mon, May 7, 2012 at 10:10 AM, Paul Bolle <pebolle@xxxxxxxxxx> wrote:
>> > On Mon, 2012-05-07 at 10:02 +0200, Sasha Levin wrote:
>> >> --- a/drivers/staging/ramster/Kconfig
>> >> +++ b/drivers/staging/ramster/Kconfig
>> >> @@ -1,6 +1,6 @@
>> >>  config RAMSTER
>> >>       bool "Cross-machine RAM capacity sharing, aka peer-to-peer tmem"
>> >> -     depends on (CLEANCACHE || FRONTSWAP) && CONFIGFS_FS=y && !ZCACHE && !XVMALLOC && !HIGHMEM
>> >> +     depends on (CLEANCACHE || FRONTSWAP) && CONFIGFS_FS=y && !ZCACHE && !XVMALLOC && !HIGHMEM && CONFIG_NET
>> >
>> > s/CONFIG_NET/NET/ again, I'd say. How was this tested?
>>
>> Hm... ran the build again with the patch and noticed it stopped
>> complaining, but apparently it wasn't enough.
>
> Well, my guess is that the errors you ran into weren't displayed because
> a dependency on an undefined Kconfig symbol (like CONFIG_NET is) will
> always fail. Ie, your patch made "RAM capacity sharing" simply disappear
> from the build.

Yup, which is not what I meant to do :)

Sorry about that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/