RE: [PATCH, v3] hwmon: coretemp: use list instead of fixed sizearray for temp data

[R, Durgadoss]

Hi,

[snip.]

> > > diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
> > > index b9d5123..fa082d5 100644
> > > --- a/drivers/hwmon/coretemp.c
> > > +++ b/drivers/hwmon/coretemp.c
> > > @@ -36,6 +36,8 @@
> > >  #include <linux/cpu.h>
> > >  #include <linux/pci.h>
> > >  #include <linux/smp.h>
> > > +#include <linux/list.h>
> > > +#include <linux/kref.h>
> >
> > I think we don't need to include kref.h now :-)
> 
> Right. :(
> Guenter, should I resend the patch or you can fix this on apply?
> 
> >
> > BTW, at some places, looks like we are using 'tdata' obtained from
> get_temp_data,
> > without checking for NULL values. Other than that, looks Ok for me.
> 
> Do you mean sysfs show methods? It should never be NULL there. If it's
> NULL, we have bug (race?) somewhere.
> 

Yes agree with you. That's fine then.

> > Acked-by: Durgadoss R <durgadoss.r@xxxxxxxxx>
> 
> Thanks.

You are welcome :-)

Thanks,
Durga
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/