Re: [PATCH 1/2] x86, reboot: revert stop_other_cpus to using IRQwith NMI fallback

From: Don Zickus
Date: Mon May 07 2012 - 11:52:16 EST


On Mon, May 07, 2012 at 03:10:21PM +0200, Ingo Molnar wrote:
>
> * Don Zickus <dzickus@xxxxxxxxxx> wrote:
>
> > The end result of this more
> > complicated-looking-diff-than-it-really-is, is a patch that
> > mostly reverts
> >
> > 3603a25 x86, reboot: Use NMI instead of REBOOT_VECTOR to stop cpus
> >
> > and instead just sticks another if-case after the REBOOT_IRQ
> > and checks to see if online_cpus are still > 1, and if so,
> > clobber the rest of the cpus with an NMI.
>
> Ok, would be nice to shape this as a 'dumb' revert as-is, and do
> the simple change in a separate patch, or so. That makes it
> easier to review (and easier to debug, should it break).

Heh. I thought about that. I can do that and resend.

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/