Re: [PATCH 3/7] perf tools: Add parser for dynamic PMU events

From: Peter Zijlstra
Date: Mon May 07 2012 - 13:11:12 EST


On Mon, 2012-05-07 at 19:05 +0200, Robert Richter wrote:
> On 07.05.12 13:01:03, Peter Zijlstra wrote:
> > On Wed, 2012-05-02 at 20:26 +0200, Robert Richter wrote:
> > > This patch adds support for pmu specific event parsers by extending
> > > the pmu handler. The event syntax is the same as for tracepoints:
> > >
> > > <subsys>:<name>:<modifier>
> >
> > I really don't like this
> >
> > > - event_legacy_tracepoint sep_dc |
> > > + event_legacy_generic sep_dc |
> >
> > That 'legacy' in there is a good hint you shouldn't be using this.
> >
> > Ideally I'd get rid of all legacy formats eventually, we really
> > shouldn't be adding new ones.
>
> Anyway, we need something like this to specify event names (pseudo
> event names in case of ibs) and userland filter options. Though, it
> must not necessarily this syntax but something else. The one above
> looks esthetic to me while some other event syntax is close to a perl
> regex. ;)

Jiri and Yan Zheng are working on something that would allow:

ibs_op/foo/

Their solution will initially get foo from sysfs (ibs_op/events/foo),
but an external lookup should also get there. Stephane also wants/needs
something like that to plug the Intel event names in.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/