Re: Regression introduced by 6f381fa344911d5a234b13574433cf23036f9467[[SCSI] scsi_lib: use correct DMA device in __scsi_alloc_queue]

[Geert Uytterhoeven]

On Mon, May 7, 2012 at 7:50 PM, Konrad Rzeszutek Wilk
<konrad.wilk@xxxxxxxxxx> wrote:
>> > reverting above mentioned git commit fixes the issue.
>>
>> Does Jame's below patch help?
>>
>> http://www.spinics.net/lists/linux-scsi/msg59106.html
>
> Yes. Âplease add Tested-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> on the latter part of that patch:

Same issue here with Atari NCR5380 SCSI on ARAnyM.
After the fix below, v3.4-rc6 boots, so

Tested-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

BTW, any git tree that has the original patch, so I don't have to commit the
HTML-mangled version from spinics to the m68k tree?

> diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
> index 351dc0b..a3a056a 100644
> --- a/drivers/scsi/hosts.c
> +++ b/drivers/scsi/hosts.c
> @@ -218,6 +218,9 @@ int scsi_add_host_with_dma(struct Scsi_Host *shost, struct device *dev,
>
> Â Â Â Âif (!shost->shost_gendev.parent)
> Â Â Â Â Â Â Â Âshost->shost_gendev.parent = dev ? dev : &platform_bus;
> + Â Â Â if (!dma_dev)
> + Â Â Â Â Â Â Â dma_dev = shost->shost_gendev.parent;
> +
> Â Â Â Âshost->dma_dev = dma_dev;
>
> Â Â Â Âerror = device_add(&shost->shost_gendev);

Gr{oetje,eeting}s,

            Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
             Â Â -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/