Re: [PATCH] gpio: langwell: Prevent possible NULL pointer dereferencein the demux handler.

[Krzysztof Wilczynski]

Hi,

[...]
>> - Â Â chip->irq_eoi(data);
>> + Â Â if (data)
>> + Â Â Â Â Â Â chip->irq_eoi(data);
>
> And how does data, which is always set as long as the interrupt exist
> prove that the chip has an eoi function?

It won't, a very good point. And as you told me (IRC) this has to be
solved on a more generic level (core handlers), and possibly
abstracted from the drivers. I will do and read through the code of
core handlers to learn more. Thanks for pointing it out and help so
far :)

KW
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/