Re: [tip:x86/platform] vsmp: Fix number of CPUs when vsmp is disabled

From: Ido Yariv
Date: Wed May 09 2012 - 04:03:43 EST


Hi Ingo,

On Tue, May 08, 2012 at 02:25:49PM +0200, Ingo Molnar wrote:
>
> On !CONFIG_SMP this produces the following build failure:
>
> arch/x86/kernel/vsmp_64.c:171:6: error: âsetup_max_cpusâ undeclared (first use in this function)
>
> Do you want to keep vSMP on UP? If not then you could add a
> 'depends on SMP' to the vSMP Kconfig entry, avoiding the whole
> UP problem space.

Oops, sorry for that.

vsmp_64.c is built even if CONFIG_X86_VSMP is not set, so even if we set
this dependency, it will not fix this issue.
How about the following CONFIG_SMP check instead?

Thanks,
Ido.