Re: linux-next: build failure after merge of the sound-asoc tree

[Linus Walleij]

On Thu, May 10, 2012 at 6:33 AM, Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:

> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> In file included from sound/soc/ux500/ux500_msp_dai.c:21:0:
> include/linux/mfd/dbx500-prcmu.h:614:19: error: redefinition of 'prcmu_abb_read'
> include/linux/mfd/db8500-prcmu.h:673:19: note: previous definition of 'prcmu_abb_read' was here
> include/linux/mfd/dbx500-prcmu.h:619:19: error: redefinition of 'prcmu_abb_write'
> include/linux/mfd/db8500-prcmu.h:678:19: note: previous definition of 'prcmu_abb_write' was here
> include/linux/mfd/dbx500-prcmu.h:630:19: error: redefinition of 'prcmu_config_clkout'
> include/linux/mfd/db8500-prcmu.h:643:19: note: previous definition of 'prcmu_config_clkout' was here
> include/linux/mfd/dbx500-prcmu.h:692:20: error: redefinition of 'prcmu_ac_wake_req'
> include/linux/mfd/db8500-prcmu.h:683:20: note: previous definition of 'prcmu_ac_wake_req' was here
> include/linux/mfd/dbx500-prcmu.h:694:20: error: redefinition of 'prcmu_ac_sleep_req'
> include/linux/mfd/db8500-prcmu.h:685:20: note: previous definition of 'prcmu_ac_sleep_req' was here
> sound/soc/ux500/ux500_msp_dai.c:23:27: fatal error: mach/hardware.h: No such file or directory
> sound/soc/ux500/ux500_msp_i2s.c:21:27: fatal error: mach/hardware.h: No such file or directory
>
> Possibly caused by commit 3592b7f69a54 ("ASoC: Ux500: Add MSP I2S-driver").
>
> I have used the version of the sound-asoc tree from next-20120508 for today.

The PRCMU driver is only available on the UX500 platforms so building
on x86_64 does not make sense.

Ola/Mark: a simple patch like this should solve the issue I think?

diff --git a/sound/soc/ux500/Kconfig b/sound/soc/ux500/Kconfig
index 9b0ae4e..f454f06 100644
--- a/sound/soc/ux500/Kconfig
+++ b/sound/soc/ux500/Kconfig
@@ -4,6 +4,7 @@
 menuconfig SND_SOC_UX500
        tristate "SoC Audio support for Ux500 platform"
        depends on SND_SOC
+       depends on MFD_DB8500_PRCMU
        help
                Say Y if you want to enable ASoC-support for
                any of the Ux500 platforms (e.g. U8500).


But it seems it has a wider dependency on some MOP500 board
stuff being merged first, which is more of a problem I think, part
of that is pending in the Ux500 tree.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/