Re: [PATCH] TWL6040: fix build error

From: Paul Gortmaker
Date: Thu May 10 2012 - 22:58:46 EST


[Re: [PATCH] TWL6040: fix build error] On 11/05/2012 (Fri 04:50) Sasha Levin wrote:

> On Fri, May 11, 2012 at 12:49 AM, Paul Gortmaker
> <paul.gortmaker@xxxxxxxxxxxxx> wrote:
> > On Thu, May 10, 2012 at 2:44 PM, Sasha Levin <levinsasha928@xxxxxxxxx> wrote:
> >> Fixes build error due to missing of_property_read_u32.
> >
> > Yes, I saw the same on x86-64 allyesconfig -- which means that in addition to
> > this missing header, it needs to have a Kconfig dependency that limits
> > it to just being enabled on the platforms where it physically is possible to
> > have the hardware.  I'm guessing limiting to ARM would be a good start?
>
> I'm not sure how the actual hardware looks or even what it does, i
> just wanted to make sure that it doesn't break my x86 build. Which is
> why I'd rather not modify anything further than what I did in this
> patch.

Of course -- I was in the same boat. I wasn't expecting you in
particular to add the Kconfig dependency, but rather instead I was
hoping someone who knows the platform details would make a proper one.

Paul.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/