Re: [PATCH 1/5] Staging ipack: fix a few sparse warnings

[Dan Carpenter]

On Mon, May 14, 2012 at 12:41:25PM +0200, Samuel Iglesias Gonsalvez wrote:
>  	/* Read status register */
> -	status_reg = readw((unsigned short *) (tpci200->info->interface_regs +
> +	status_reg = readw((void __iomem *) (tpci200->info->interface_regs +
>  					       TPCI200_STATUS_REG));
>  

Later in the patch, you do the right thing which is to declare this
as an __iomem pointer in the header.  The cast here can be removed
and it all fits on one line.

Remove it in a follow on patch if you want.  Same for several of the
other casts in this patch.

regards,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/