Re: [PATCH] netdev/phy: Make get_phy_id() static and quitEXPORTing it.

From: David Miller
Date: Wed May 16 2012 - 01:00:01 EST


From: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
Date: Tue, 15 May 2012 17:32:08 -0400

> [[PATCH] netdev/phy: Make get_phy_id() static and quit EXPORTing it.] On 15/05/2012 (Tue 13:46) David Daney wrote:
>
>> From: David Daney <david.daney@xxxxxxxxxx>
>>
>> This function is only referenced from within phy_device.c, so there is
>> no reason to export it. In fact, we can make it static.
>
> I did a bit of data mining to remind myself why it was exported. Back
> in a01b3d766c (v2.6.26) gianfar_mii was using it. That then got merged
> into fsl_pq_mdio.c and gianfar_mii was deleted. Then finally in commit
> 28d8ea2d568 (v3.2) the one instance of code that was using it got
> removed. So, I think this should be OK (but for net-next, though).
>
> Acked-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/