Re: [PATCH] gpio: Emma Mobile GPIO driver V2

[Arnd Bergmann]

On Wednesday 16 May 2012, Magnus Damm wrote:
> > irq_domain_add_legacy() exists for existing static ranges, which there is
> > really no reason to be adding in new board/platform support. You don't
> > have to worry about virq overlap since irq_create_mapping() already wraps
> > on top of irq_alloc_desc_xxx() for lookup.
> 
> So I intentionally made use of the legacy domain in the non-DT case.
> This because I want to let the SoC code set the static IRQ ranges via
> platform data.

I think it's generally better to use just one code path for both cases,
if you need both DT and non-DT support, which means you would always
use irq_domain_add_legacy. Once you have the final patch to convert it
to DT, you can remove the legacy domain and just convert it to linear.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/