RE: linux-next: build failure after merge of the final tree (stagingtree related)

From: Dan Magenheimer
Date: Wed May 16 2012 - 10:17:35 EST


> From: Greg KH [mailto:greg@xxxxxxxxx]
> Subject: Re: linux-next: build failure after merge of the final tree (staging tree related)
>
> On Wed, May 16, 2012 at 08:06:59PM +1000, Stephen Rothwell wrote:
> > Hi Greg,
> >
> > After merging the final tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_map_object':
> > drivers/staging/zsmalloc/zsmalloc-main.c:704:3: error: implicit declaration of function 'set_pte' [-
> Werror=implicit-function-declaration]
> > drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_unmap_object':
> > drivers/staging/zsmalloc/zsmalloc-main.c:738:3: error: implicit declaration of function
> '__flush_tlb_one' [-Werror=implicit-function-declaration]
> >
> > Presumably caused by commit 49b81a3c7415 ("ramster: switch over to
> > zsmalloc and crypto interface") which now has CONFIG_RAMSTER selecting
> > CONFIG_ZSMALLOC explicitly which in turn ignores the dependency of
> > CONFIG_ZSMALLOC on X86 ...
> >
> > I have reverted that commit for today.
>
> Ick, sorry about that.
>
> Dan, care to send me a follow-on patch, or do you just want me to revert
> this patch from my tree for now?

Rats. Sorry.

Greg, given that the solution for making zsmalloc portable
is still being debated[1] and it doesn't look like it will
be finalized before the looming window, I guess the
best choice is to revert the patch and ramster will fall
back to its captive copy of the less-efficient-but-portable
xvmalloc for now. :-(

Thanks and sorry for the churn,
Dan

[1] http://comments.gmane.org/gmane.linux.kernel.mm/78470
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/