Re: [PATCH] staging: comedi: Convert struct addi_boardinitialization to C99 format

[Greg KH]

On Wed, May 16, 2012 at 05:51:56PM -0700, H Hartley Sweeten wrote:
> Convert the struct addi_board initialization to C99 format and remove
> all the NULL or 0 initializers. This makes maintaining and editing the
> code simpler and less error prone.
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
> Cc: Ian Abbott <abbotti@xxxxxxxxx>
> Cc: Mori Hess <fmhess@xxxxxxxxxxxxxxxxxxxxx>
> 
> ---
> 
> This patch is a bit large but should be easy enough to review.
> It does incease the size of the source file in bytes but it reduces
> the lines of code by 1103 lines.
> 
> There are 6 checkpatch warnings about lines over 80 characters
> due to the long CamelCase names for some of the functions.
> "Fixing" these actually hurts the readability of the code. The
> checkpatch warnings will be addressed later by renaming the
> CamelCase functions.

Nice job, this driver is a pain to read...

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/