Re: [PATCH 7/8] MIPS: smp: Warn on too early irq enable

[Sergei Shtylyov]

Hello.

On 17-05-2012 14:10, Yong Zhang wrote:

> From: Yong Zhang<yong.zhang@xxxxxxxxxxxxx>

> Just to catch a potential issue.

   Grammar nitpicking ahead. :-)

> Signed-off-by: Yong Zhang<yong.zhang0@xxxxxxxxx>
> ---
>   arch/mips/kernel/smp.c |    5 +++++
>   1 files changed, 5 insertions(+), 0 deletions(-)

> diff --git a/arch/mips/kernel/smp.c b/arch/mips/kernel/smp.c
> index 042145f..0d48598 100644
> --- a/arch/mips/kernel/smp.c
> +++ b/arch/mips/kernel/smp.c
> @@ -130,6 +130,11 @@ asmlinkage __cpuinit void start_secondary(void)
>
>   	synchronise_count_slave();
>
> +	/*
> +	 * irq will be enabled in ->smp_finish(), enable it too early

   s/enable/enabling/

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/