Re: [PATCH 2/6] pstore/ram: Add console messages handling

From: Colin Cross
Date: Thu May 17 2012 - 14:28:19 EST


On Thu, May 17, 2012 at 1:40 AM, Anton Vorontsov
<anton.vorontsov@xxxxxxxxxx> wrote:
> This is all straightforward: we just use the last region for
> console logging. If there's just one region, we fall-back to
> the old behaviour: just a oops/dumps logging.
>
> Signed-off-by: Anton Vorontsov <anton.vorontsov@xxxxxxxxxx>

I don't think using the last region is the right way to handle this.
We often use very large regions for ramconsole, up to 2MB. Using a
single region would require a 2MB region for console and a 2MB region
for oops, which is far too large.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/