Re: [PATCH RFC tip/core/rcu 2/2] rcu: Fix broken strings in RCU'ssource code.

[Paul E. McKenney]

On Thu, May 17, 2012 at 03:23:22PM -0700, Josh Triplett wrote:
> On Thu, May 17, 2012 at 03:12:45PM -0700, Paul E. McKenney wrote:
> > @@ -1184,27 +1183,27 @@ rcu_torture_printk(char *page)
> >  	}
> >  	cnt += sprintf(&page[cnt], "%s%s ", torture_type, TORTURE_FLAG);
> >  	cnt += sprintf(&page[cnt],
> > -		       "rtc: %p ver: %lu tfle: %d rta: %d rtaf: %d rtf: %d "
> > -		       "rtmbe: %d rtbke: %ld rtbre: %ld "
> > -		       "rtbf: %ld rtb: %ld nt: %ld "
> > -		       "onoff: %ld/%ld:%ld/%ld "
> > -		       "barrier: %ld/%ld:%ld",
> > +		       "rtc: %p ver: %lu tfle: %d rta: %d rtaf: %d rtf: %d ",
> >  		       rcu_torture_current,
> >  		       rcu_torture_current_version,
> >  		       list_empty(&rcu_torture_freelist),
> >  		       atomic_read(&n_rcu_torture_alloc),
> >  		       atomic_read(&n_rcu_torture_alloc_fail),
> > -		       atomic_read(&n_rcu_torture_free),
> > +		       atomic_read(&n_rcu_torture_free));
> > +	cnt += sprintf(&page[cnt], "rtmbe: %d rtbke: %ld rtbre: %ld ",
> >  		       atomic_read(&n_rcu_torture_mberror),
> >  		       n_rcu_torture_boost_ktrerror,
> > -		       n_rcu_torture_boost_rterror,
> > +		       n_rcu_torture_boost_rterror);
> > +	cnt += sprintf(&page[cnt], "rtbf: %ld rtb: %ld nt: %ld ",
> >  		       n_rcu_torture_boost_failure,
> >  		       n_rcu_torture_boosts,
> > -		       n_rcu_torture_timers,
> > +		       n_rcu_torture_timers);
> > +	cnt += sprintf(&page[cnt], "onoff: %ld/%ld:%ld/%ld ",
> >  		       n_online_successes,
> >  		       n_online_attempts,
> >  		       n_offline_successes,
> > -		       n_offline_attempts,
> > +		       n_offline_attempts);
> > +	cnt += sprintf(&page[cnt], "barrier: %ld/%ld:%ld",
> >  		       n_barrier_successes,
> >  		       n_barrier_attempts,
> >  		       n_rcu_torture_barrier_error);
> 
> A change like this placates tools like checkpatch, but doesn't actually
> fix the problem. :)

The formatting would frustrate most people trying to grep for the
debugfs output anyway, though.

But the main reason for the change is that it makes it easier to see
which quantity goes with which sprintf() format specifier.  (Lazy and
self-indulgent, I know!!!)

						Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/