Re: [RFC PATCH 00/10] Use __kernel_[u]long_t for x32 user space compatibility

From: David Daney
Date: Thu May 17 2012 - 19:07:51 EST


On 05/17/2012 03:13 PM, H.J. Lu wrote:
From: H.J. Lu<hjl.tools@xxxxxxxxx>

This patch set changes a number of places where the kernel headers are
exported to user space and currently use explicit "long" or "unsigned
long" to use __kernel_[u]long_t in order to be compatible with the x32
user space ABI. These location are places where x32 uses the x86-64
ABI.


Has anybody checked how this affects MIPS n32 userspace?

I think it totally breaks it.

In addition, 109a1f32 (sysinfo: Use explicit types in <linux/sysinfo.h>) is probably bad. I think it may need to be reverted, or somebody should fix all the __kernel_{,u}long_t definitions for the ABI that may have been broken by the change.

It is quite possible that some, or even all, of these locations should
really use dedicated types, but in the meantime this gives the correct
results which the current headers do not.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/