Re: [PATCH v2 2/2] x86: Added read_mostly declaration/definition tovars from smp.h

[Ingo Molnar]

* Vlad Zolotarov <vlad@xxxxxxxxxxx> wrote:

> Added a "read-mostly" qualifier to the following variables in smp.h:
>  - cpu_sibling_map
>  - cpu_core_map
>  - cpu_llc_shared_map
>  - cpu_llc_id
>  - cpu_number
>  - x86_cpu_to_apicid
>  - x86_bios_cpu_apicid
>  - x86_cpu_to_logical_apicid
> 
> As long as all the variables above are only written during the initialization,
> this change is meant to prevent the false sharing and improve the
> performance on large multiprocessor systems.
> 
> Signed-off-by: Vlad Zolotarov <vlad@xxxxxxxxxxx>
> Signed-off-by: Shai Fultheim <shai@xxxxxxxxxxx>
> ---
>  arch/x86/include/asm/apic.h    |    2 +-
>  arch/x86/include/asm/smp.h     |   16 ++++++++--------
>  arch/x86/kernel/apic/apic.c    |    6 +++---
>  arch/x86/kernel/setup_percpu.c |    2 +-
>  arch/x86/kernel/smpboot.c      |    8 ++++----
>  5 files changed, 17 insertions(+), 17 deletions(-)


This does not build on !SMP kernels that has APIC enabled.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/