Re: [PATCH 1,2/4 v2] slub: use __cmpxchg_double_slab() at interruptdisabled place

[Pekka Enberg]

On Thu, 17 May 2012, Christoph Lameter wrote:

> On Fri, 18 May 2012, Joonsoo Kim wrote:
> 
> > get_freelist() is only called by __slab_alloc() with interrupt disabled,
> > so __cmpxchg_double_slab() is suitable.
> >
> > unfreeze_partials() is only called with interrupt disabled,
> > so __cmpxchg_double_slab() is suitable.
> 
> Combine these sentences as well.
> 
> Acked-by: Christoph Lameter <cl@xxxxxxxxx>

You should add a comment on top of get_freelist() and unfreeze_partials() 
that they now *require* interrupts to be disabled.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/